On Sun, Sep 19, 2004 at 06:46:51PM -0000, [EMAIL PROTECTED] wrote:
> gmazza      2004/09/19 11:46:51
>   Modified:    src/java/org/apache/fop/area AreaTreeModel.java
>                         StorePagesModel.java
>                src/java/org/apache/fop/fo CharIterator.java FOText.java
>                         OneCharIterator.java RecursiveCharIterator.java
>   Removed:     src/java/org/apache/fop/fo AbstractCharIterator.java
>   Log:
>   1.)  Removed unused getTitle() within AreaTreeModel; I believe can be obtained
>   from fo.pagination.PageSequence object where needed.

PageSequence is an FO node. It can at best provide the title FO
node. getTitle() provides the Title area. Perhaps it is there for the
convenience of renderers?
>   2.)  Combined AbstractCharIterator and CharIterator interface into single
>   abstract CharIterator class.
Don't you believe in the separation of Interface and abstract
implementing superclass? If AbstractCharIterator adds nothing to the
interface, it is better to remove this abstract superclass. It does
implement a few methods, though.

Regards, Simon

Simon Pepping
home page: http://www.leverkruid.nl

Reply via email to