Yes, you're absolutely correct.  Up until now my "ROT" was pure line
count -- if just one, don't bother with the isDebugEnabled().  But now I see
the need to also check the parameter supplied.  BTW, if you're making
changes to the code today if you can take care of this it would be
appreciated.  Else I'll return it when I next make a CVS commit.


----- Original Message ----- 
> General rule of thumb: Always surround a debug log statement with a
> isDebugEnabled() check if the log statement is non-trivial (i.e.
> not a simple constant String).

Reply via email to