DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36082>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36082 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO ------- Additional Comments From [EMAIL PROTECTED] 2005-08-10 11:47 ------- I've had a look at this patch and there's a problem. You removed the call to FOUserAgent.getStream(). FOUserAgent can be subclassed by users to supply special behaviour on certain URIs, i.e. that they can supply their own InputStream for a particular URI. I've seen your TODO line in openStream() and this tells me that you didn't realize what that the getStream() method was for. The other problem is indeed the test case. I'm reluctant to add it to the other test cases because of the hard-coded absolute paths. With some tweaking of the testcase2fo.xsl stylesheet the attribute replacement mechanism could probably be enhanced to replace only subsets of a string. That way, we could provide a default variable holding the root directory of the test cases as an absolute path. BTW, while I was looking at image loading earlier I had that idea of creating a small object which carries the original URI, the resolved URL, if any, and the opened stream with it so it is easier to give Batik a base URI for the SVG handling. As far as I can remember that's currently not possible since only the InputStream is passed to the analyzer. Something like that. Maybe that helps further with the relative URI resolution stuff (especially with SVG, of course). So I'm not going to apply this patch right now. I'd rather you look at this again. Thanks! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
