On Fri, 7 Oct 2005 08:51 pm, Jeremias Maerki wrote: > Great work!!!! That's a lot of new functionality. And lots of new > test cases! You're a prime role model. :-) > > I've got a comment and a question: > - I assume the change in StaticPropertyList was a mistake: > http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apac >he/fop/fo/StaticPropertyList.java?rev=307055&r1=307054&r2=307055&view= >diff I put those lines in so I could set a break point for debugging when a particular property was accessed. But then I forgot to remove them. I usually add a comment like //shit when I add something like that and then search for these before committing. However, in this case I didn't follow my own procedure and there you go.
>- Any particular reason why chose 1mpt and not 0mpt for BPD on > space and none leader in LeaderLayoutManager? > http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apac >he/fop/layoutmgr/inline/LeaderLayoutManager.java?rev=307055&r1=307054& >r2=307055&view=diff > Yes, any areas with a 0 BPD are dropped somewhere. For an area to be rendered it needs to have a BPD > 0 and 1 was the least disruptive number I could come up with. > On 07.10.2005 11:00:56 Manuel Mall wrote: > > I just committed a fairly sizeable patch related to all the work on > > inline objects done over the last weeks. > > > > While I hope it hasn't broken anything, given its size and my > > inexperience with the overall FOP software base, it is actually > > likely that there are some unexpected regressions. > > > > Please don't hesitate to 'scream' if you see or notice something > > you feel is wrong or inappropriate or could be coded better or ... > > > > Manuel > > Jeremias Maerki Manuel
