DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
------- Additional Comments From [EMAIL PROTECTED] 2006-10-04 12:15 -------
Thanks for your patch. I have a few comments.
1. Your patch for src/java/org/apache/fop/layoutmgr/PageBreakingAlgorithm.java
/** the logger for the class */
protected static Log classLog =
+ /** the logger for the instance */
+ private static Log log = classLog;
Why don't you remove 'protected static Log classLog'?
Re the comment, a static variable is for the class, not for the instance.
2. In the LayoutManagers, there is a protected static Log instance in
org.apache.fop.layoutmgr.AbstractBaseLayoutManager, assigned to class
protected static Log log = LogFactory.getLog(LayoutManager.class)
This is used by all LayoutManagers. I can imagine that you find this too coarse,
and prefer to see a different logger for each LayoutManager, but then it would
be better to do so for each LayoutManager.
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.