DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41514>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41514





------- Additional Comments From [EMAIL PROTECTED]  2007-02-08 02:28 -------
(In reply to comment #10)
> I had a short look at the patch, and I have the following comments:
> 
> Do not change the 0.93 documentation but the trunk documentation:
> src/documentation/content/xdocs/trunk/configuration.xml, etc.

Oops, yes I missed that.  I will update the patch file to make changes to the
trunk xdocs and not 0.93.
 
> TargetResolution is a property of FOUserAgent because it may easily vary with
> each run. It is not a good idea if you move properties around. They are in
> FopFactory or in FOUserAgent for a reason. See
> http://xmlgraphics.apache.org/fop/trunk/embedding.html.

There is no real change here.  TargetResolution is still a property of
FOUserAgent, it is just configured from FopFactory and propagated to the
FOUserAgent.  As before, the value of this property in FOUserAgent can be
programmatically set at anytime during rendering.

> Although I did not (and will not) have enough time to look at the patch in
> detail, I have the feeling that it addresses more than user configuration
> validation. It does some refactoring. That requires careful inspection.

It may look like quite a large patch, but there really isn't very much
refactoring, just stricter value checking which addresses issues raised in bugs
40288 and 40120.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to