DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41514>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41514





------- Additional Comments From [EMAIL PROTECTED]  2007-02-08 07:20 -------
(In reply to comment #13)
> (In reply to comment #12)
> > Created an attachment (id=19545)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19545&action=view) 
[edit] [edit]
> > main patch file
> 
> I have another comment: this would be better to put the test config files in a
> subdirectory of test/ --typically, test/conf.

The reason I didn't do this is because of concerns raised about this patch
containing too much refactoring.  But I am in agreement that it makes sense for
the config files to live separately.  So if nobody objects I will provide them
in a separate zip attachment and move/remove the existing test/test.xconf to
test/config/test.xconfig.

> Also, the tests fail with a SAXParseException: "The processing instruction
> target matching "[xX][mM][lL]" is not allowed". Can aynyone else try and tell 
> me
> if the problem also occurs?

Do you have the stack trace for this?

> Finally, I got a small error applying your patch. I could recover easily, but
> next time be sure to create it from scratch and against the latest svn 
> revision.
> 
> Thanks,
> Vincent

Sorry about this, I will try to be mindful of this in the future.  Ideally I
would do this everytime, but there have been a number of revisions to this patch
and preparing a new patch from scratch every half day is not a good use of time.
 Its not always practically quick and easy to do as I am in parallel cracking on
with other FOP development work.

regards,

Adrian.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to