DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41831>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41831





------- Additional Comments From [EMAIL PROTECTED]  2007-03-24 04:07 -------

Hi Adrian,

Had some more time to look into this. I'm currently on a more detailed stroll 
through your code. Just 
like to know what I commit, nothing personal. ;-)

The change to MacFontFinder is working as it should.

In the meantime, if you make any more changes, try to post incremental patches 
only containing the 
classes you know for certain were altered since the last diff. I'll do my best 
to keep up.

Here's already a few suggestions for change, but there's no immediate necessity 
to create a new patch. 
I've already corrected some things locally, mainly style issues.
For the javadocs, we like to have the class-level doc right before the class 
declaration, after the import 
header. As you have it, Eclipse collapses them with the license header. :(

In WindowsFontFinder, there's that hacky fallback you're commenting on: if 
shelling out is necessary, 
then note that 'set windir' will immediately return only the line containing 
'windir=', so there's no need 
to iterate over all environment variables.

Still looking further, but these are some things I've already stumbled upon. 
Stay tuned.

Cheers

Andreas

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to