DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=42785>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42785 ------- Additional Comments From [EMAIL PROTECTED] 2007-07-05 01:41 ------- (In reply to comment #2) Hi Max, Thanks for your patch. However, I'm slightly reluctant to apply it as is. I have a few questions: - I can understand the need for an intrinsic baseline-shift for images, especially if the image represents, say, a mathematical formula... That said, in plain FO I think I would use the alignment-adjust property (XSL-FO 1.1, 7.14.1). Now I easily understand that it would be difficult to store this information separately from the image but, still, shouldn't the image have an intrinsic alignment-adjust instead? The description of alignment-adjust says that this property especially applies to images which lack of a baseline-table. Whereas baseline-shift recreates a whole baseline-table for the area. Granted, this doesn't change many things but I think it would be more consistent. - IIC, the intrinsic baseline-shift may only be a length? Isn't that limiting? If the image is scaled for whatever reason, then the length no longer makes sense. A percentage would probably be more robust. Especially if it's expressed in terms of the image's height. And guess what, that's exactly the case with alignment-adjust. BTW, percentages are the reason why the other FOs return a Length object for their baseline-shift. > Some other comments while I am at it: > > External graphic dimensions are specified in millipoints (int), where > as inline-graphics are specified in pts (float). I have followed the > same pattern for this patch, but find it quite inconsitent. I'm not sure of what you are referring to? For both ExternalGraphic and InstreamForeignObject the intrinsic dimensions are specified in millipoints. WDYT? Thanks, Vincent -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.