Vincent,

why did you disable this warning here? What's there to clarify? I
stumbled over this when trying to merge the latest changes from trunk
into the feedback branch.

On 10.03.2008 21:52:48 vhennebert wrote:
> Author: vhennebert
> Date: Mon Mar 10 13:52:43 2008
> New Revision: 635686
> 
> URL: http://svn.apache.org/viewvc?rev=635686&view=rev
> Log:
> Bugfix: forced break ignored when the minimum height of a table-row isn't 
> reached
> 
<snip/>
RowGroupLayoutManager:

>              row.setHeight(rowHeights[rgi]);
> -            row.setExplicitHeight(explicitRowHeights[rgi]);
> -            if (maxCellBPD > row.getExplicitHeight().max) {
> -                log.warn(FONode.decorateWithContextInfo(
> -                        "The contents of row " + (row.getIndex() + 1) 
> -                        + " are taller than they should be (there is a"
> -                        + " block-progression-dimension or height constraint 
> on the indicated row)."
> -                        + " Due to its contents the row grows"
> -                        + " to " + maxCellBPD + " millipoints, but the row 
> shouldn't get"
> -                        + " any taller than " + row.getExplicitHeight() + " 
> millipoints.", 
> -                        row.getTableRow()));
> -            }
> -        }
> -        if (log.isDebugEnabled()) {
> -            log.debug("rowGroup:");
> -            for (int i = 0; i < rowHeights.length; i++) {
> -                log.debug("  height=" + rowHeights[i] + " explicit=" + 
> explicitRowHeights[i]);
> +            row.setExplicitHeight(explicitRowHeight);
> +            // TODO re-enable and improve after clarification
> +//            if (maxCellBPD > row.getExplicitHeight().max) {
> +//                log.warn(FONode.decorateWithContextInfo(
> +//                        "The contents of row " + (row.getIndex() + 1) 
> +//                        + " are taller than they should be (there is a"
> +//                        + " block-progression-dimension or height 
> constraint
> +//                        + " on the indicated row)."
> +//                        + " Due to its contents the row grows"
> +//                        + " to " + maxCellBPD + " millipoints, but the row 
> shouldn't get"
> +//                        + " any taller than " + row.getExplicitHeight() + 
> " millipoints.", 
> +//                        row.getTableRow()));
> +//            }
> +            if (log.isDebugEnabled()) {
> +                log.debug("  height=" + rowHeights[rgi] + " explicit=" + 
> explicitRowHeight);
>              }
>          }
<snip/>


Jeremias Maerki

Reply via email to