https://issues.apache.org/bugzilla/show_bug.cgi?id=45113
--- Comment #2 from Alexander Stamenov <[EMAIL PROTECTED]> 2008-06-02 11:13:09 PST --- (In reply to comment #1) > Interesting! Thanks for the patch. > > The only thing I'm wondering about is the order of the tests in PDFFactory: > after your change, /all/ URIs using the file-protocol will generate a /Launch > action. If I'm correct, the test for the .pdf extension should happen first > (?) I am glad you find this patch useful. At first I added this check as penultimate in order to honor the special treatment of PDFs. After that I decided that specifying the protocol has to be with more weight. But I think this is the place for people more involved in the project to decide that particular order. > Since it does include one new file, we have to ask: > Does Apache already have your ICLA on file from contributions to other > projects? The short answer is no. Actually it is now that I understand for the ICLA. I found this addition very small so if it is ok with the community I have no objections to contribute this code without the ICLA. If any further documenting is needed to meet any criteria I am willing to do it. After all this will be my first contribution to an open source project. :) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
