https://issues.apache.org/bugzilla/show_bug.cgi?id=47311
--- Comment #29 from Vincent Hennebert <[email protected]> 2009-07-28 07:23:29 PST --- (In reply to comment #26) > Hi Vincent, > > (In reply to comment #22) <snip/> > > A note about the patch: it seemed more sensible to me to deal with integer > > values rather than double. Indeed every length value is internally converted > > into a whole number expressed in mpt (AFAICT). That means that I'm using > > Rectangle instead of Rectangle2D, and I changed some parameters into some > > classes accordingly (mainly, o.a.f.layoutmgr.Page.java, > > o.a.f.area.PageViewport.java). But then I noticed that the AreaTreeParser > > reads > > the value of the "bounds" attribute as double instead of integer. AFAIK, the > > XML area tree is produced with whole numbers for the page boundaries; I > > don't > > see why a user would change that into decimal numbers (which would mean a > > precision below the mpt!). So I also modified the AreaTreeParser. I don't > > think > > this may create any problem? > > I don't think so. I'll extract your changes from your patch and apply that > separately. That should make it easier for Peter, too. I've just committed a change to also replace Rectangle2D with Rectangle in PDFFactory and PDFPage. Forgot to do that in my patch. > > Also, a few questions: > <snip/> > > > fox:crop-offset: <length>{1,4} > > > Default: 0pt > > > Same behaviour as with fox:bleed. > > > The MediaBox is calculated by expanding the BleedBox by the crop offsets. > > > > Just to be sure: values will be allowed to be negative, right? > > Negative values don't make much sense, if I didn't miss anything. Actually not, because the simple-page-master's width and height would define the TrimBox. What I had in mind is to make the BleedBox coincide with the simple-page-master's boundaries, and define a TrimBox inside it. I was thinking that sometimes the document may be easier to design this way (especially when you want areas with dark backgrounds to bleed off the boundary of the final page). I guess it's not actually the case. <snip/> Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
