Hi Jeremias, Thanks for committing the patch.
> BTW, while working on this it occurred to me that with the embedding > functionality, we're actually making page segment handling overly complicated: > we always need a replacement image that the layout image is actually working > with. I'm not saying that this addition was a bad one, but we should think > about making it easier in the future, namely by supporting AFP page segments True > directly through fo:external-graphic. The first step here would be native > embedding support (just reading the intrinsic size of the page segment). A In the case when the page segment is not available at AFP generation time (to be referenced), maybe another method of specifying the image metrics, rather than a placeholder image? For standard images like a company logo etc, the metrics maybe easier to distribute than this? > second step could even be decoding page segments and supporting them for other > output formats. Just a thought. ..and perhaps compressing if we can support that in the future! Cheers, Pete On Thu, Oct 7, 2010 at 8:48 AM, <[email protected]> wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=49379 > > Jeremias Maerki <[email protected]> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|NEW |RESOLVED > Resolution| |FIXED > > --- Comment #3 from Jeremias Maerki <[email protected]> 2010-10-07 03:48:24 > EDT --- > Patch applied with modifications as discussed: > http://svn.apache.org/viewvc?rev=1005350&view=rev > > Thanks, Peter, and sorry for the long time it took to process your patch! > > BTW, while working on this it occurred to me that with the embedding > functionality, we're actually making page segment handling overly complicated: > we always need a replacement image that the layout image is actually working > with. I'm not saying that this addition was a bad one, but we should think > about making it easier in the future, namely by supporting AFP page segments > directly through fo:external-graphic. The first step here would be native > embedding support (just reading the intrinsic size of the page segment). A > second step could even be decoding page segments and supporting them for other > output formats. Just a thought. > > -- > Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug. >
