Hi Simon,

On 18/02/11 11:17, Simon Pepping wrote:
> Vincent,
> 
> Please, do not revert other committers' changes. Discuss them if you
> have objections.

Well I believe I already do that, don’t I?

In this case the change had no relation to the commit message, and was
actually reverting what I did in rev. 1035610. That’s what made me think
that it really was an accidental change and that there would be no
problem with me fixing it.

Vincent


> Simon
> 
> On Wed, Feb 16, 2011 at 03:19:29PM -0000, vhennebert apache org wrote:
>> Author: vhennebert
>> Date: Wed Feb 16 15:19:29 2011
>> New Revision: 1071282
>>
>> URL: http://svn.apache.org/viewvc?rev=1071282&view=rev
>> Log:
>> Reverted changes accidentally made to toString in rev. 1071048
>>
>> Modified:
>>     
>> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java
>>
>> Modified: 
>> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java
>> URL: 
>> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java?rev=1071282&r1=1071281&r2=1071282&view=diff
>> ==============================================================================
>> --- 
>> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java
>>  (original)
>> +++ 
>> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java
>>  Wed Feb 16 15:19:29 2011
>> @@ -507,11 +507,11 @@ public class AlignmentContext implements
>>      /** {@inheritDoc} */
>>      public String toString() {
>>          StringBuffer sb = new StringBuffer(64);
>> -        sb.append("ah=").append(areaHeight);
>> -        sb.append(" lp=").append(lineHeight);
>> -        sb.append(" ap=").append(alignmentPoint);
>> -        sb.append(" ab=").append(alignmentBaselineIdentifier);
>> -        sb.append(" bs=").append(baselineShiftValue);
>> +        sb.append("areaHeight=" + areaHeight);
>> +        sb.append(" lineHeight=" + lineHeight);
>> +        sb.append(" alignmentPoint=" + alignmentPoint);
>> +        sb.append(" alignmentBaselineID=" + alignmentBaselineIdentifier);
>> +        sb.append(" baselineShift=" + baselineShiftValue);
>>          return sb.toString();
>>      }

Reply via email to