I like to give a little time to remove such code in case someone wishes to dispute/revert my commented removal. If I don't remove in a reasonable time, then feel free to remind me.
Thanks, G. On Tue, Apr 24, 2012 at 9:15 AM, Vincent Hennebert <[email protected]>wrote: > On 21/04/12 05:11, [email protected] wrote: > > Author: gadams > > Date: Sat Apr 21 04:11:44 2012 > > New Revision: 1328580 > > > > URL: http://svn.apache.org/viewvc?rev=1328580&view=rev > > Log: > > Tweak comment. > > Why not just remove the code? It’s versioned anyway. Very soon that > piece of code will stop compiling if uncommented. And also stop making > sense as the context will evolve. > > Vincent > > > > Modified: > > > xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java > > > > Modified: > xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java > > URL: > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?rev=1328580&r1=1328579&r2=1328580&view=diff > > > ============================================================================== > > --- > xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java > (original) > > +++ > xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java > Sat Apr 21 04:11:44 2012 > > @@ -423,7 +423,7 @@ public class TTFFile { > > /* > > * Removing this feature, since it violates > XSL-FO and Unicode > > * semantics. All characters used in an > XSL-FO file (once decoded from > > - * the document encoded) are interpreted as > Unicode code points. > > + * the document encoding) are interpreted > as Unicode code points. > > * This precludes using Unicode code points > in the Basic Latin range > > * for any purpose other than use as Basic > Latin characters. In > > * order to use characters in the Wingding > or Symbols font, then > > @@ -433,17 +433,17 @@ public class TTFFile { > > * as defined by the font manufacturer and > supported by some cmap > > * provided in the font. [GA] 2012-04-20 > > * > > - if (encodingID == 0 && j >= 0xF020 && j <= > 0xF0FF) { > > - //Experimental: Mapping 0xF020-0xF0FF > to 0x0020-0x00FF > > - //Tested with Wingdings and Symbol TTF > fonts which map their > > - //glyphs in the region 0xF020-0xF0FF. > > - int mapped = j - 0xF000; > > - if (!eightBitGlyphs.get(mapped)) { > > - //Only map if Unicode code point > hasn't been mapped before > > - unicodeMappings.add(new > UnicodeMapping(glyphIdx, mapped)); > > - > mtxTab[glyphIdx].getUnicodeIndex().add(new Integer(mapped)); > > - } > > - } > > + * if (encodingID == 0 && j >= 0xF020 && j > <= 0xF0FF) { > > + * //Experimental: Mapping 0xF020-0xF0FF > to 0x0020-0x00FF > > + * //Tested with Wingdings and Symbol > TTF fonts which map their > > + * //glyphs in the region 0xF020-0xF0FF. > > + * int mapped = j - 0xF000; > > + * if (!eightBitGlyphs.get(mapped)) { > > + * //Only map if Unicode code point > hasn't been mapped before > > + * unicodeMappings.add(new > UnicodeMapping(glyphIdx, mapped)); > > + * > mtxTab[glyphIdx].getUnicodeIndex().add(new Integer(mapped)); > > + * } > > + * } > > */ > > > > // Also add winAnsiWidth > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > >
