Hi,

I’ve recently stumbled upon this o.a.f.complexscripts.bidi.BidiClass
that appears to be generated. I think it should be moved to the
build/gensrc directory. Reasons are:
• It doesn’t need to be understood and maintained by developers in the
  same way as other classes. Changes will be made to the generator and
  not this class. Therefore it doesn’t need to follow the usual style
  and readability rules.
• Despite the warning at the beginning of the class, there is still
  a risk that it is accidentally modified during some refactoring
  session.
• There is also a risk that the generator is modified and this class not
  re-generated, introducing a discrepancy that may take some time to be
  tracked down.

Like any other generated file, I think the generation should happen at
any clean build.

Any objection?

Thanks,
Vincent

Reply via email to