[ 
https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563699#comment-13563699
 ] 

Luis Bernardo commented on FOP-2044:
------------------------------------

the patch is a bit involved but seems to work well. but I am not sure the 
behavior implemented is the desired one in some corner cases. the 
implementation applies the remainCharCount and pushCharCount values (the 
minimum number of characters to allow before and after a break point) to all 
words when in my view should only apply to the beginning of the first and the 
end of the last words.

an example: INFLATED_EGOS. I think INFLATED_E-GOS should be allowed but the 
patch does not allow because E-GOS is not allowed (if remainCharCount is 2).

comments?
                
> [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
> ----------------------------------------------------------------
>
>                 Key: FOP-2044
>                 URL: https://issues.apache.org/jira/browse/FOP-2044
>             Project: Fop
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 1.0
>         Environment: Operating System: All
> Platform: All
>            Reporter: Thomas Schraitle
>            Assignee: Robert Meyer
>         Attachments: output.pdf, patch.diff, uppercase-hyphen.fo, 
> uppercase-hyphen.pdf
>
>
> Consider the attached FO file which combines words of lowercase and uppercase 
> letters.
> As it is expected, the word "expected" is hyphenated correctly (example 2). 
> Also the uppercase "SUCCESS". Even combined with underlines before and after 
> the word (see example 4 and 5).
> However, if there is another word (like OCF_SUCCESS) the word isn't 
> hyphenated at all anymore. I don't know if this is an expected behaviour or 
> an issue in the hyphenation patterns. Interestingly, XEP from RenderX 
> hyphenates it as "OCF_SUC-CESS". As far as I know, they use also the TeX 
> hyphenation patterns as FOP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to