[ 
https://issues.apache.org/jira/browse/FOP-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777280#comment-13777280
 ] 

Vincent Hennebert commented on FOP-1749:
----------------------------------------

Leaving boxPreceding to false when the box has zero width would go against the 
principles of the algorithm, so will most probably cause bugs in other cases. 
The width of the glue should somehow be taken into account when another 
iteration of the outer loop (while (!(somethingAddedd && splitLength > 
availableLength))) is run.
But this code that iterates through Knuth elements and computes total 
length/shrink/stretch is present in many places. Maybe there's an opportunity 
to factorise things and re-use one, proper, implementation.

Vincent
                
> [PATCH] infinite loop in footnotes (see also #47424)
> ----------------------------------------------------
>
>                 Key: FOP-1749
>                 URL: https://issues.apache.org/jira/browse/FOP-1749
>             Project: Fop
>          Issue Type: Bug
>          Components: page-master/layout
>    Affects Versions: trunk
>         Environment: Operating System: Windows XP
> Platform: PC
>            Reporter: Heidi Vanparys
>         Attachments: bug47424.patch, c.fo, fop-1749.diff
>
>
> This patch solves the problem of an infinite loop in footnotes as reported in 
> FOP-1678.
> The infinite loop occurred in 
> org.apache.fop.layoutmgr.PageBreakingAlgorithm.getFootnoteSplit(int, int, 
> int, int, boolean).
> This patch does not solve the problem of another infinite loop in footnotes 
> as reported in bugs 48063 and 48162. This infinite loop occurs in 
> org.apache.fop.layoutmgr.PageBreakingAlgorithm.createFootnotePages(KnuthPageNode).
>  The test attached to 48063 is converted to a testcase and added to the list 
> of disabled testcases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to