[ 
https://issues.apache.org/jira/browse/FOP-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793828#comment-13793828
 ] 

Alexey Neyman commented on FOP-1749:
------------------------------------

Attached a patch for footnote positioned below the end of the page. When adding 
child blocks to Footnote area, Footnote.addBlock does not account for 
space-before/after traits, as for example NormalFlow does. Modified the 
previously posted test case to check for footnote's top-offset as well.

> [PATCH] infinite loop in footnotes (see also #47424)
> ----------------------------------------------------
>
>                 Key: FOP-1749
>                 URL: https://issues.apache.org/jira/browse/FOP-1749
>             Project: Fop
>          Issue Type: Bug
>          Components: page-master/layout
>    Affects Versions: trunk
>         Environment: Operating System: Windows XP
> Platform: PC
>            Reporter: Heidi Vanparys
>         Attachments: bug47424.patch, c.fo, fop-1749-2106-combined.diff, 
> fop-1749.diff, fop-1749-top-offset.diff
>
>
> This patch solves the problem of an infinite loop in footnotes as reported in 
> FOP-1678.
> The infinite loop occurred in 
> org.apache.fop.layoutmgr.PageBreakingAlgorithm.getFootnoteSplit(int, int, 
> int, int, boolean).
> This patch does not solve the problem of another infinite loop in footnotes 
> as reported in bugs 48063 and 48162. This infinite loop occurs in 
> org.apache.fop.layoutmgr.PageBreakingAlgorithm.createFootnotePages(KnuthPageNode).
>  The test attached to 48063 is converted to a testcase and added to the list 
> of disabled testcases.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to