Given that, with the exception of yourself, the findbugs exclude file has been continually updated to produce no warnings, I conclude that the FOP dev ha implicitly or explicitly accepted it for quite some time.
We don't need to do anything to the excludes file to make it acceptable. It is acceptable now. That doesn't mean it couldn't be improved by additional review and revision, but that is true of the entire FOP code base. On Mon, Jun 16, 2014 at 3:32 AM, Vincent Hennebert <vhenneb...@gmail.com> wrote: > Rather than repeating myself, I’ll just point to the past conversations > on this topic: > http://markmail.org/message/pg7p2khityg4bjya > http://markmail.org/message/taztvj2ms7x6tryb > > This one is particularly interesting: > http://markmail.org/message/lthcstbbmhtbrsva > It more or less matches my own experience with FindBugs. > > The only way to ensure zero FindBugs warnings is to enforce it in > continuous integration, just like we did about Checkstyle. But before > doing that, you’ll have to come up with a satisfying exclude file that > filters out uninteresting warnings, and get the community to agree on > it. > > Vincent > > > > On 15/06/14 17:03, Glenn Adams wrote: > >> I'm getting tired of fixing findbugs warnings that people are leaving in >> the >> code base. I'm going to start inserting comments that will break >> compiles/builds if people don't check and fix these. Today I see four new >> warnings: >> >> *Dodgy Warnings* >> >> *Code* >> >> >> >> *Warning* >> >> *BC* >> >> >> >> >> Unchecked/unconfirmed cast from org.apache.fop.fo.FONode to >> org.apache.fop.fo.flow.MultiCase in >> org.apache.fop.layoutmgr.LayoutManagerMapping$ >> MultiCaseLayoutManagerMaker.make(FONode, >> List) >> >> >> >> >> *BC* >> >> >> >> >> Unchecked/unconfirmed cast from org.apache.fop.fo.FONode to >> org.apache.fop.fo.flow.MultiSwitch in >> org.apache.fop.layoutmgr.LayoutManagerMapping$ >> MultiSwitchLayoutManagerMaker.make(FONode, >> List) >> >> >> >> >> >> *BC* >> >> >> >> >> Unchecked/unconfirmed cast from org.apache.fop.fo.FObj to >> org.apache.fop.fo.flow.MultiSwitch in new >> org.apache.fop.layoutmgr.MultiSwitchLayoutManager(FObj) >> >> >> >> >> >> *RCN* >> >> >> >> >> Redundant nullcheck of footnoteList, which is known to be non-null in >> org.apache.fop.layoutmgr.list.ListItemLayoutManager. >> getCombinedKnuthElementsForListItem(List, >> List, LayoutContext) >> >> >> >> >> >>
