[ 
https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575949#comment-14575949
 ] 

Andreas L. Delmelle commented on FOP-2469:
------------------------------------------

Investigating a bit further the creation and usage of the LayoutContext, I am 
beginning to think that all usages of LC.newInstance() are actually candidates 
for a switch to copyOf() or offspringOf().
The former would copy the whole parent context, all flags and settings 
included, which may be undesirable in some cases, but is likely to be what one 
would expect from a child context anyway. The latter currently copies only one 
single flag, but could easily be extended to serve other purposes as well. At 
least, it seems it was intended to be an in-between of newInstance() and 
copyOf().
The explicit LC init calls (copyPendingMarks(), setRefIPD()...) in the various 
LMs still remain, but would then override the inherited settings. The settings 
that are not explicitly set or unset by the LM can then be assumed to be 
propagated, which is exactly the behaviour we are looking for.

> [PATCH] auto table layout
> -------------------------
>
>                 Key: FOP-2469
>                 URL: https://issues.apache.org/jira/browse/FOP-2469
>             Project: FOP
>          Issue Type: Bug
>          Components: layout/unqualified
>    Affects Versions: trunk
>         Environment: Windows 7, JDK 7
>            Reporter: Gregor Berg
>            Assignee: Andreas L. Delmelle
>             Fix For: trunk
>
>         Attachments: 2015-05-13-auto-table-layout.patch, 
> 2015-05-27-LM-to-LC-refactoring.patch, FOP2469-auto-table-layout.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can 
> not only handle linebreaks and pagebreaks, but it also copes with auto tables 
> in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version 
> of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to