+1 to treating katello more closely with foreman core On Thu, May 26, 2016 at 10:58 AM, Stephen Benjamin <[email protected]> wrote:
> > > ----- Original Message ----- > > From: "Dominic Cleal" <[email protected]> > > To: [email protected] > > Sent: Thursday, May 26, 2016 5:42:33 AM > > Subject: Re: [foreman-dev] Merge foreman-bats into Forklift > > > > On 25/05/16 17:25, Ewoud Kohl van Wijngaarden wrote: > > > On Wed, May 25, 2016 at 10:38:04AM -0400, Stephen Benjamin wrote: > > >> I can understand separating it from development tools, so what about > > >> moving > > >> Katello's bats to foreman-bats? > > > > > > What would then be the primary way of getting the latest bats tests? A > > > script to clone the foreman-bats repository? > > > > Assuming you just want to get foreman-bats to use its helpers then yes, > > just clone the repo and they should be usable. Freight does something > > similar to use another library of BATS helpers > > (https://github.com/freight-team/freight/blob/master/Makefile#L88). > > > > Else you could use a submodule/tree to stay with a particular version. > > The helpers could always be moved into their own repo if necessary. > > I don't "just" want foreman-bats helpers, that's just one reason to merge > the projects. I think they should be in the same repo together, wherever > that is, and work with Forklift's Vagrant setup. > > One of the benefits of how Forklift does things is that you can easily > `vagrant up centos7-bats` and run katello bats locally. Why should > foreman-bats stay in its own repo and maintain an entirely separate > and different vagrant configuration? > > > - Stephen > > > > -- > > Dominic Cleal > > [email protected] > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to [email protected]. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
