On 19/07/16 13:19, otheus uibk wrote: > After discussions with domcleal, the simplest solution seems to be to > modify the external_node_v2.rb file, which is replaced as node.rb on the > production system. > > I have created such a patch .... BUT I feel the strong need to refactor > the code. A lot of this code does things that are completely mysterious > to me (what's "push facts" for?)
https://theforeman.org/manuals/1.12/index.html#3.5.5FactsandtheENC briefly describes these functions at the bottom of the section. If you wish to refactor it, go ahead and submit pull requests. Best to be precise about what it's changing and why, plus try to split it into logical changes separate to whatever features you're implementing. -- Dominic Cleal [email protected] -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
