I would say: if we want to make large-scale changes that would make sense, let's move away from option hashes to keywords. This would justify the large-scale changes in my eyes, and the non-hash rocket syntax just falls more naturally in that case. And Rubocop can take a rest here.
I share the lzap's view on Rubocop, but if you've followed some of the discussions around that so far, a) you know that, b) you know how the discussions usually end (hint https://github.com/theforeman/foreman/pull/3617) -- Ivan On Fri, Aug 19, 2016 at 9:39 AM, Tomas Strachota <[email protected]> wrote: > On 08/18/2016 03:16 PM, Ori Rabin wrote: >> >> Hello, >> >> The hash rocket syntax is still in use throughout the project. >> New prs are sometimes submitted with the x: y syntax instead and then >> asked to change. >> >> As discussed on IRC yesterday there should be consistency and there is >> an option to autofix with rubocop if the style is changed to change >> existing code with less effort. >> >> Since right now the lowest ruby version supported in core is 2.0 and >> there are even discussions about dropping that, should this syntax change? > > > I have no strong opinion about rocket vs. json syntax and I can live with > both. I started to lean towards json style recently. There's one thing I'm > afraid of though: > the autofixing with rubocop, which will complicate cherry-picks. So I'd say > let's start writing new code with json-like hashes and slowly iterate > towards it rather then autofix the whole codebase. > >> >> Ori >> >> -- >> You received this message because you are subscribed to the Google >> Groups "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected] >> <mailto:[email protected]>. >> For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
