Hello all, There are a few things with puppet-katello that I think we can fix and make it more modular and closer to foreman / a basic foreman plugin.
# Odd permissions on katello bundler file https://github.com/Katello/puppet-katello/blob/8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L8-L13 All other bundler files are owned by root:root and since packaging is used I think this can be changed to root:root. # Odd config file https://github.com/Katello/puppet-katello/blob/8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L15-L23 Again this file is owned by foreman while all other configs are owned by root:root. Here I see no reason either. Another thing is that this has a before foreman::database and the migrate but puppet-foreman executes the database class before placing the config. What's the reasoning behind this? # Katello apache fragment is mostly pulp and candlepin https://github.com/Katello/puppet-katello/blob/8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L25-L28 This sets up pulp and candlepin for which I'd propose to introduce two separate fragments. It also manages keepalive which IMHO belongs in puppet-foreman. # Katello config dir https://github.com/Katello/puppet-katello/blob/8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L30-L35 Can we get rid of this? # Future Ideally puppet-katello would be more like a profile module. We'd have a foreman::plugin::katello that installs just the katello plugin to Foreman. Then it also combines other modules to have a katello profile. That means we have to move some things to other modules (pulp::config::foreman instead of sneaking it into puppet-katello?). Please give your thoughts on my ramblings. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
