On Tue, Aug 23, 2016 at 11:02 AM, Ewoud Kohl van Wijngaarden < [email protected]> wrote:
> Hello all, > > There are a few things with puppet-katello that I think we can fix and > make it more modular and closer to foreman / a basic foreman plugin. > > # Odd permissions on katello bundler file > > https://github.com/Katello/puppet-katello/blob/ > 8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L8-L13\ > > All other bundler files are owned by root:root and since packaging is > used I think this can be changed to root:root. > +1 > > # Odd config file > > https://github.com/Katello/puppet-katello/blob/ > 8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L15-L23 > > Again this file is owned by foreman while all other configs are owned by > root:root. Here I see no reason either. > > Another thing is that this has a before foreman::database and the > migrate but puppet-foreman executes the database class before placing > the config. What's the reasoning behind this? > This is likely due to some migrations requiring some of the settings in the config file to work properly. On the Foreman side, this would potentially affect taxonomies? On the Katello side, this would affect some of our migrations that unfortunately reach out to backend services. I think its a change that if we wanted to make would need to be thoroughly tested to see what if any impact. > > # Katello apache fragment is mostly pulp and candlepin > > https://github.com/Katello/puppet-katello/blob/ > 8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L25-L28 > > This sets up pulp and candlepin for which I'd propose to introduce two > separate fragments. > > It also manages keepalive which IMHO belongs in puppet-foreman. > We could look into splitting the fragments up. I want to say the keepalive was due to needing it and not having a way (that would get into the code base in time) for us to set it. This could likely be updated. > > # Katello config dir > > https://github.com/Katello/puppet-katello/blob/ > 8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L30-L35 > > Can we get rid of this? > +1 > > # Future > > Ideally puppet-katello would be more like a profile module. We'd have a > foreman::plugin::katello that installs just the katello plugin to > Foreman. Then it also combines other modules to have a katello profile. > That means we have to move some things to other modules > (pulp::config::foreman instead of sneaking it into puppet-katello?). > This sounds like baking into puppet-pulp and puppet-candlepin, as examples, knowledge of Katello and Foremanisms. We've largely tried to keep those modules as independent modules that the community can widely use and in which we tell them what we need altered and changed. There is currently a decent chunk of orchestration between katello-pulp-candlepin that makes ripping them apart harder. Thats the part that would need some thought and re-work: what we configure and how we orchestrate. Loosening that boundary as much as possible would help here I think. Eric > > Please give your thoughts on my ramblings. > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Eric D. Helms Red Hat Engineering Ph.D. Student - North Carolina State University -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
