One thing we could do is to set TargetRubyVersion in rubocop to ensure a consistent rubocop experience across platforms (see https://git.io/viosZ). Certain cops only apply to certain Ruby versions like the FrozenStringLiteralComment is only run when the Ruby version is 2.3+. By default TargetRubyVersion is 2.0 but it looks like hound has TargetRubyVersion set indirectly to 2.3 since they have a .ruby-version file set: https://git.io/viosC.
David On Thu, Sep 15, 2016 at 4:49 AM, Lukas Zapletal <[email protected]> wrote: > Hey, > > since we have upgraded Rubocop, it tries to warn about frozen string > literals pragma comment for each individual change file. This PR > disabled it: > > https://github.com/theforeman/foreman/pull/3846 > > If you encounter these warnings, rebase on top of develop branch and > push again. > > -- > Later, > Lukas #lzap Zapletal > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
