+1 to the comments above, moving forward with React will allow us to drop turbolinks at some point without a noticeable decrease in UI performance - at least that is my hope.
On Wed, Dec 6, 2017 at 5:46 PM, Ohad Levy <ohadl...@gmail.com> wrote: > > > On Wed, Dec 6, 2017 at 5:10 PM, Walden Raines <wrai...@redhat.com> wrote: > >> I am seeing more and more issues [1][2] around turbolinks and I'm >> wondering if it's time to remove it from foreman. I have seen it >> recommended that one shouldn't use the back button in foreman; I thought >> that request was reserved for poorly written php sites that resubmit forms >> when the back button is pressed, we're better than that! :) >> >> Are the benefits of turbolinks worth the cost? Does anyone have any >> metrics on the difference in page load times with and without >> "turbo"links? >> >> Any additional thoughts on its removal? >> >> > I welcome the proposal to remove turbolinks, having said that, there are > a few things that we must take into account. > > 1. we should not just remove turbo links and loose all functionaitly - > this will greatly impact current ui performance. > 2. we should come up with an alternative plan - which is a roadmap to a > SPA or semi SPA which will render the usage cases of tubolinks today not > required. > > IMHO - I would suggest we look into converting the vertical nav into a > react component (some work already done at [1]), than using that as a base > for a SPA, we should default to fetching content, either via api and using > react to render it, or (which is the very common case) to let the server > render html and replace a content div, this will mimic the current way > turbolinks more or less works and will surely speed up the page load times. > > We would need to move things like session / login / permissions etc into > the browser if we go that path > > Ohad > > > > [1] https://github.com/patternfly/patternfly-react/pull/88 > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
