Since https://github.com/theforeman/foreman/pull/5083 was merged most of my issues with turbolinks have been fixed so I'm fine keeping it until we can replace it with a true single page application.
On Thu, Dec 7, 2017 at 10:02 AM, Daniel Lobato Garcia <elobat...@gmail.com> wrote: > On 12/06, Walden Raines wrote: > > I am seeing more and more issues [1][2] around turbolinks and I'm > wondering > > if it's time to remove it from foreman. I have seen it recommended that > > one shouldn't use the back button in foreman; I thought that request was > > reserved for poorly written php sites that resubmit forms when the back > > button is pressed, we're better than that! :) > > If someone suggests the back button shouldn't be used within foreman > because that breaks something - it's our fault. I recall some problems > in some pages like Products/Errata etc.. but haven't seen any in a whlie > > The request is used by Basecamp, GitHub, and modern Ruby applications, > but honestly that's just an ad-hominem. (notice the blue bar when you click > on a link in GitHub) > > > > > Are the benefits of turbolinks worth the cost? Does anyone have any > > metrics on the difference in page load times with and without > > "turbo"links? > > Do the test, it's considerably faster to use it, I'm happy to provide > metrics. > In fact for cached pages it can easily be 100ms (/subnets, /settings, etc) > > https://www.speedshop.co/2015/05/27/100-ms-to-glass-with- > rails-and-turbolinks.html > > In fact, there's room to make it faster (data-turbolinks-permanent) > > > > > Any additional thoughts on its removal? > > Unless there are serious blockers or anything that cannot be done with > Turbolinks that we need to do, I really oppose this. If you have another > alternative that's not pushState that makes Foreman faster and is as easy > to > use, I'd be glad to hear it > > > > > Cheers, > > Walden > > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1522740 > > [2] http://projects.theforeman.org/issues/21480 > > > > -- > > You received this message because you are subscribed to the Google > Groups "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > -- > Daniel Lobato Garcia > > @dLobatog > blog.daniellobato.me > daniellobato.me > > GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 > Keybase: https://keybase.io/elobato > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
