Hi Joe, thanks for your feedback!!! I guess I need some clarification on how the tests are executed.
Am 15.08.2015 um 18:43 schrieb Joe Mistachkin:
I've reviewed the changes. I'm curious why some of the th1 tests were moved? None of the tests you moved actually modify the repository.
I have to admit that I don't understand some of the details of the test framework yet. But to my understanding the 'artifact' command needs a repository, not for changing it, but for accessing the artifact id itself. Maybe for clarification: here is my test workflow * checkout branch into clean directory * configure / build * change to clean directory *outside the build tree*! * run the test for that clean env My dir structure looks like this then * <devroot>/fossil-ckol/<clean checkout here> * <devroot>/fossil-test/<empty in the beginning> from within the empty '<devroot>/fossil-test' (!!!) I call: tclsh ../fossil-ckol/test/tester.tcl ../fossil-ckol/fossil th1 and with your suggestion to have the artifact test in th1.test I get the following result: ***** End of th1: 11 errors so far ****** ***** Final result: 11 errors out of 222 tests ***** Failures: th1-checkout-1 th1-checkout-2 th1-header-2 th1-footer-2 th1-footer-3 th1-artifact-3 th1-artifact-5 th1-artifact-7 th1-artifact-9 th1-globalState-1 th1-globalState-8 That were exactly the ones that I originally moved. Maybe somee can shed some light on how these tests should be executed? I might have a wrong understanding here.
If they really do need to be moved, it might be better to avoid doing it on the feature branch, that way the new tests would stand out better.
You are right, I should not have mixed those changes. Happy Coding! Chris _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
