Hi Joe,
Am 16.08.2015 um 19:16 schrieb Joe Mistachkin:
The tests in "th1.test" are all read-only with respect to the
repository (and checkout); therefore, they are harmless to simply run
while in the checkout directory. They should all pass there (and
they do).
For your new tests, having them in a new file is required since they
make modifications to the repository and checkout.
The problem is that we have threetypes of tests now:
1. tests that don't need a repo at all
2. tests which need repository but do not change anything
3. tests that change things within a repo
th1.test contain tests from 1+2 and the type 2 tests assume that
they are executed from with a checkout. IMHO tests should not assume
and environment but setup it up themselve to ensure proper consistency.
Therefore I would rather group type 2+3 and put the repo initialization
code on top.
Also there is another caveat:
My goal (and also the one stated in the release checklist) would be
to run *all* tests from one place. With the current structure of th1.test
this is not possible now. E.g. th1 needs to be run from within the build
dir and th1-repo needs to be run from an empty dir outside of the
build tree.
Wouldn't it be good if we'd have all tests to be able to run from one place
without manually selecting some for a different type of execution?
What do you think of having the [dir] command return a list-of-lists
(e.g. with the name, size, and time for each entry)? The underlying
SQL query is already producing this data and it might be quite useful
from scripts.
+1 but I haven't coded "list-of-lists" yet, therefore I skipped it in
the initial implementation :-).
Chris
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
