On 1/7/2016 8:36 PM, Andy Bradford wrote:
Thus said Ross Berteig on Thu, 07 Jan 2016 11:54:03 -0800:
Letting  the full  test  suite run  in-tree  fails almost  immediately
because  amend.test called  repo_init  which cannot  be  run inside  a
checkout.

Any tests that require their own repository will fail if you run it from
within an open checkout. There are many test files that use repo_init.

Exactly. And I think it is a good idea for the test suite to run from a folder outside of all checkouts for a lot of reasons.

   * What am I missing here?

I usually do something like:

TESTDIR=/tmp/fossil-test
SRC=/path/to/repository
FOSSIL=$SRC/fossil

mkdir $TESTDIR
cd $TESTDIR
tclsh $SRC/test/tester.tcl $FOSSIL

Aside from the convenient variable declarations, that is what failed for me.

Does that work for you (anyone?) right now from trunk?

   * Does "make test" work for anyone right now?

I've never used it, didn't even know  there was a test target. I usually
follow:

http://www.fossil-scm.org/index.html/doc/trunk/test/release-checklist.wiki

Specifically, what I mentioned above is really just step 1.

Which is where I started.

And that fails for me because a passel of cases in file1.test and th1.test appear to require an open checkout, but don't provide one by calling repo_init.

The very last test case in th1.test uses th1 to read a source file from the repository, and so would require that it specifically run from an open checkout of fossil's own repository. That could easily be changed (and IMHO should be changed) to use a file checked into a test repo instead, which would also eliminate a surprise dependence of a th1 test case on the content of ajax/cgi-bin/fossil-json.cgi.example.

Before I dive into writing more test cases, I want to have the confidence that I understand the existing test suite, and having a clean build from trunk fail to pass all tests is not helping...
--
Ross Berteig                               r...@cheshireeng.com
Cheshire Engineering Corp.           http://www.CheshireEng.com/

_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to