On 4/25/2016 5:34 AM, David Vines wrote:
I think I've addressed the comments made on my proposed changes for
adding CLI support for tech notes and hence believe it is ready for
further review/comments and/or potentially merging into trunk.

I've built it in all the configurations I build and test on Windows. To do that I had to remove a C99-ism. As far as I know, fossil and SQLite deliberately still build with C89.

Since things have happened on trunk, I've merged trunk into the branch, and configured, built and tested the result on Windows. It passes all tests that trunk passes.

I have no way to evaluate any interaction with the new encrypted repository support since I don't own a license to SEE. I'd imagine that there should be no issue since the only command that seems to have needed any special handling so far is "fossil all", but perhaps someone with SEE available could confirm that the new "fossil wiki" features still work as expected.

Before I recommend a merge to trunk, I want to review the documentation and tests to make sure that features like the friendly names for mime types are both documented and tested.

I do think we are getting close.
--
Ross Berteig                               r...@cheshireeng.com
Cheshire Engineering Corp.           http://www.CheshireEng.com/
+1 626 303 1602
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to