On Oct 11, 2017, at 8:32 AM, Andy Bradford 
<amb-sendok-1510324379.pjighmdgkblbjijmf...@bradfords.org> wrote:
> 
> *** Parse error in /home/amb/download/tarballs/fossil: Missing dependency 
> operator (Makefile:70)
> *** Parse error: Need an operator in 'endif' (Makefile:74)

My change on line 70 of Makefile is a GNU make conditional.  I’m guessing 
you’re using BSD make or some other non-GNU make, which doesn’t grok that 
syntax.

(And if not, *someone* will doubtlessly use a non-GNU make to build Fossil, a 
fact I probably should have thought of before checking it in.  Sorry.)

All that conditional does is prevent an automatic reconfigure if Makefile is 
out of date but you’re saying “make clean”.  In that case, you’re “quitting the 
game,” so it was a minor optimization to prevent unnecessary work.  That being 
the case, I just decided to remove the GNU make specific conditional on the 
dependency rule.  Now running “make” in that condition means it reconfigures, 
*then* cleans itself.

If someone here is feeling the itch to put this optimization back, do realize 
that you can’t use autosetup to test this, because autosetup doesn’t know which 
“make” you will eventually use.  If multiple versions are installed, testing 
the flavor of “make” doesn’t help, because you might intend to type “gmake” on 
FreeBSD or “bsdmake” on macOS.

The best I could tell, the only way to fix this would be to add GNUmakefile and 
BSDmakefile files, each with an idiomatic version of this autoreconfigure 
target, then include Makefile from each of those.  That’s way more complexity 
than the feature deserves.
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to