On Nov 20, 2018, at 5:43 AM, Stephan Beal <sgb...@googlemail.com> wrote:
> 
> It seems to me (based solely off of the docs, rather than understanding the
> implementation) that that could be implemented much more simply:
> 
> proc check-function-in-lib {function libs {otherlibs {}}} {
>    set _LIBS [get-define LIBS]
>    set found [cc-check-function-in-lib $function $libs $otherlibs]
>    define LIBS $_LIBS
>    return $found
> }

If you don’t care about the lib_$function stuff, then perhaps so.

However, I suspect the idea of that proc is wrong-headed from the start.  It 
should be possible to reorder that auto.def file so that LIBS ends up in the 
proper order while still using the stock autosetup version of that proc.

The hard bit is actually trying that on enough platforms to be sure it doesn’t 
become a regression.

The main lesson for you, though, is that you should try using the stock proc 
until you know you can’t.  LIBS order matters, but you’re in control of that by 
how you write your auto.def file.
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to