Hello,

I think check-in [d6bfe8d9a8] "Change default ticket viewer format to  
display ticket title as wiki. Show event summaries as wiki on the  
timeline" introduced an inconsistency, and maybe a problem.

1) When I create a new ticket with title: "Fix <hr> style in IE", I  
get the following entry in timeline
(you can view it here: 
http://dev.codingrobots.org/cgi-bin/o/shiny-theme/timeline?n=200 
):

   New ticket 3920b5e080 Fix <hr> style in IE. (user: dchest)

Which is what I excepted.

2) When I edit this ticket later, the timeline says:

   Ticket 3920b5e080 Fix style in IE status still Open with 3 other  
changes (user: dchest)

As you can see, <hr> has been omitted.

This is easy to fix....

--- src/manifest.c
+++ src/manifest.c
@@ -978,11 +978,11 @@
             pManifest->zTicketUuid, pManifest->nField,
             pManifest->nField==1 ? "" : "s"
        );
      }
    }else{
-    blob_appendf(&comment, "New ticket [%.10s] <i>%h</i>.",
+    blob_appendf(&comment, "New ticket [%.10s] <i>%s</i>.",
        pManifest->zTicketUuid, zTitle
      );
      blob_appendf(&brief, "New ticket [%.10s].", pManifest- 
 >zTicketUuid);
    }
    free(zTitle);

...where fixing means making it behave as in #2 (omitting <hr> in  
ticket title).

There's another inconsistency: /rptview, displays ticket title as is,  
without wiki formatting:

   Fix <hr> style in IE

So, how do I write <hr> in the ticket title?

If I escape it like this:

   Fix &lt;hr&gt; style in IE

I get the proper title in /tktview and in timeline:

   Fix <hr> style in IE

But I see it as is in /rptview:

   Fix &lt;hr&gt; style in IE

However, the real question is -- do we really need wiki formatting in  
titles? What's the benefit of this?

Thank you!

--
Dmitry Chestnykh
Coding Robots

http://www.codingrobots.com
[email protected]




_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to