A non-terminated char array was printing garbage in the "attachview" page.

--- ../../fossil-src-20100318142033/src/info.c  2010-03-18 10:20:53.000000000 
-0400
+++ info.c      2010-05-21 10:45:25.907388684 -0400
@@ -753,8 +753,9 @@ static void object_description(
       @ Attachment "%h(zFilename)" to
     }
     if( strlen(zTarget)==UUID_SIZE && validate16(zTarget,UUID_SIZE) ){
-      char zShort[20];
+      char zShort[11];
       memcpy(zShort, zTarget, 10);
+      zShort[10] = '\0';
       if( g.okHistory && g.okRdTkt ){
         @ ticket [<a href="%s(g.zTop)/tktview?name=%s(zShort)">%s(zShort)</a>]
       }else{


_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to