Hello,

   I got tired of retyping my key file passphrase multiple times during
a single fossil clone/pull operation, so I added passphrase caching in
the jan-clientcert branch. (It uses the OpenSSL password callback
mechanism).

   On Unix systems, there's no need to take any special notice. On
Win32, however, one needs to be aware of potential problems with calling
conventions.

   I couldn't find any calling convention macros in OpenSSL's headers,
so I'm not entirely sure what calling convention to used for the
callback function. Some Random Post On The Internet stated that OpenSSL
simply sets __cdecl as the global default. I haven't checked this, but I
did look at the function prototypes, and they do not have explicit
calling conventions.

   I believe that the default calling convention for VC++ is __stdcall,
so everything is nicely laid out in a "this will come back to bite me"
way. :(

   Should I simply add __cdecl to the callback function for
Windows-builds and hope that no one builds OpenSSL with any other
calling convention?

-- 
Kind regards,
Jan Danielsson


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to