On 21/07/2011, at 5:24 PM, Ben Summers wrote: > > On 21 Jul 2011, at 07:42, Steve Bennett wrote: >> >> On 20/07/2011, at 7:16 PM, Ben Summers wrote: >> >>> >>> I'm concerned that typing 'make' on obscure platforms builds subtly broken >>> binaries. For example, on Solaris, it'll build one which truncates your >>> passwords to 8 characters. >>> >>> I propose that we whitelist platforms where the default Makefile is known >>> to work, and force the use of ./configure for all other platforms. >>> >>> Here's an example change to the build system which only allows Linux and >>> Mac OS X to use the default Makefile: >>> >>> http://fossil-scm.org/index.html/info/14d1e44957 >>> >>> I have also corrected the documentation. Suggesting people type >>> "./configure; make" will just use the default Makefile on the platforms >>> where it really matters! You need to use the explicit "./configure; make -f >>> GNUmakefile" to pick up the autosetup generated Makefile. >> >> The autosetup/configure stuff is quite new. >> Aren't we just waiting until it has had some more testing until >> switching over to it for all (non-windows) platforms? > > Probably. It's just that the current trunk has a 'broken' fossil on Solaris > and the instructions on how to use it are wrong. > > >> >> Probably makes sense to rename Makefile to Makefile.classic and >> have configure create Makefile from Makefile.in though. > > Yes!
What say you Richard? Will you accept a patch for this change? -- µWeb: Embedded Web Framework - http://uweb.workware.net.au/ WorkWare Systems Pty Ltd W: www.workware.net.au P: +61 434 921 300 E: [email protected] F: +61 7 3391 6002 _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
