On Wed, May 30, 2012 at 08:09:54PM -0400, Richard Hipp wrote:
> On Wed, May 30, 2012 at 6:52 PM, Thomas Stover <[email protected]> wrote:
>
> > On Wed, 30 May 2012 18:14:54 -0400
> > Richard Hipp wrote:
> >
> > > Can you send the output of "diff -u" please? I can't quite figure
> > > out how to apply the diff below.
> > >
> >
> > See if that works. Admittedly I never use diff.
> >
>
> The new diff is much better. Thanks.
>
> But now I see that the patch is not quite right:
>
> (1) You always use GET instead of the value in the zMethod variable
> (2) You always use HTTP/1.0 instead of the value in zProtocol
> (3) The date format is wrong
> (4) You append two extra fields not mentioned in the wikipedia
> documentation on the Common Log Format
>
The diff is actually for what apache calls the combined log format which
includes the referer and user-agent at the end.
> That's all I see at the moment. Maybe fix those thing and send me a new
> diff and we'll try again?
>
>
> >
> > --- src/althttpd.c 2011-12-28 15:42:28.000000000 -0500
> > +++ althttpd.c 2012-05-30 17:49:59.000000000 -0400
> > @@ -205,6 +205,11 @@
> > rScale = 1.0/(double)sysconf(_SC_CLK_TCK);
> > chdir((zRoot && zRoot[0]) ? zRoot : "/");
> > if( (log = fopen(zLogFile,"a"))!=0 ){
> > +#ifdef COMMON_LOG_FORMAT
> > + fprintf(log, "%s - - [%s +0000] \"GET %s HTTP/1.0\" %d %d \"%s\"
> > \"%s\"",
> > + zRemoteAddr, zDate, zScript, zReplyStatus, nOut,
> > zReferer, zAgent); +
> > +#else
> > fprintf(log, "%s %s %s://%s%s %s %s %d %d %g %g %g %g %d %d %s
> > %s\n", zDate, zRemoteAddr, zHttp, zHttpHost, zScript, zReferer,
> > zReplyStatus, nIn, nOut,
> > @@ -213,8 +218,8 @@
> > rScale*sTms.tms_cutime,
> > rScale*sTms.tms_cstime,
> > (int)(now - beginTime),
> > - nRequest, zAgent, zRM
> > - );
> > + nRequest, zAgent, zRM);
> > +#endif
> > fclose(log);
> > nIn = nOut = 0;
> > }
> >
> >
> > --
> > www.thomasstover.com
> > _______________________________________________
> > fossil-users mailing list
> > [email protected]
> > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
> >
>
>
>
> --
> D. Richard Hipp
> [email protected]
> _______________________________________________
> fossil-users mailing list
> [email protected]
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
--
James Turner
[email protected]
_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
