Hello,

When I build Fossil with "gcc -Wall" on Linux, I get the following warning:

./src/file.c: In function ‘file_set_mtime’:
./src/file.c:408: warning: implicit declaration of function ‘utimes’

I think file.c should probably include sys/time.h on all unix-like platforms instead of just on Cygwin. The man pages for Linux, OpenBSD, and Solaris all indicate that utimes() resides in sys/time.h.

Interestingly, the warning does not occur on OpenBSD or Solaris, because sys/time.h is included indirectly. On OpenBSD sys/stat.h includes sys/time.h, and on Solaris sys/types.h includes sys/select.h which includes sys/time.h.

(Relevant versions: CentOS 6.3, Ubuntu 12.04, OpenBSD 5.2, Solaris 10 Update 10, and Fossil "version 1.25 [89ab1185bf] 2012-12-06 02:51:56 UTC".)

Edward

_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to