On Fri, May 3, 2013 at 8:26 AM, Richard Hipp <d...@sqlite.org> wrote:
> > > On Fri, May 3, 2013 at 8:09 AM, Jan Nijtmans <jan.nijtm...@gmail.com>wrote: > >> 2013/5/3 Jan Nijtmans <jan.nijtm...@gmail.com>: >> > Any other ideas? Should "fossil clean" be undo-able like >> > "fossil revert", or do we expect that people setting >> > "ignore-glob" know what they are doing? .... >> >> Hm. I think an undo-able "fossil clean" is a good idea anyway >> for such a dangerous command. And it's easy to implement. >> Done now: >> <http://www.fossil-scm.org/index.html/info/5b4cece445> >> > > > I have avoiding making "fossil clean" undoable in the past because some of > the deleted files might be really massive. (SQLite test databases come > first to mind - 100MB or more. But also tarballs, videos, *.iso files, > huge log files from test runs, etc.) To make all this undoable, the > content of these massive files must be written into the > ".fslckout"/"_FOSSIL_" database. > > Note also that the maximum BLOB size in SQLite is 1GB, which means that > you cannot save the content of a file larger than that. > > For all other examples of undo, the files that get undone are already > located in the repository, so they are all presumably of a reasonable size. > > For an undoable "fossil clean", maybe we need to create a ".trash" > subdirectory and store the undoable deleted files there? > Or, perhaps there is a size limit (say 10MiB) above which "cleaned" files are not undoable. Prompt for conformation prior to deleting an oversized file that will not be undoable. -- D. Richard Hipp d...@sqlite.org
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
