On Tue, May 28, 2013 at 6:10 AM, Laurens Van Houtven <_...@lvh.io> wrote:
> Hi, > > > I'd like to know what sort of code review practices Fossil users employ. I > believe this has come up at least twice: I've asked about it myself back in > 2010, and Russ Paielli from the Scala team in 2011. > > All the projects I currently work on have some explicit form of code > review, be it: > > - Github pull requests > - explicit code review processes on top of an existing tool (such as > twisted + trac) > - Launchpad merge proposals > > All of these tend to operate on the merging of a branch: the changes get > reviewed before being merged into master/trunk/... > > It is my understanding that Fossil doesn't come with such a tool for code > reviews. Additionally, the entire point of autosync by default is to > prevent having to branch and merge all the time. So, I'm wondering, do you: > > 1. not do code review at all > 2. only do code review on major things that get their own branch, not > reviewing small changes to trunk > 3. have a code review system not based on merging into trunk > 4. something else? > There is a "pending review" branch ( http://www.fossil-scm.org/fossil/timeline?c=pending-review&y=ci) on the Fossil self-hosting repository now! Fossil also has the ability to move a check-in to a different branch after it has been committed. Sometimes people will check-in some code by mistake, or which is rejected by reviewers, and in those cases we simply move the check-in off to a dead-end branch, often called "mistake". See http://www.fossil-scm.org/fossil/timeline?r=mistake for some examples of this. > > thanks in advance > lvh > > _______________________________________________ > fossil-users mailing list > fossil-users@lists.fossil-scm.org > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users > > -- D. Richard Hipp d...@sqlite.org
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
