On Fri, Aug 16, 2013 at 12:27 PM, Stephan Beal <[email protected]>wrote:
> The only sorting checks i see being done in manifest_parse(), though are
> for the card names themselves, but i see no validation of the order of the
> remainder of the card.
>
Many card types must be unique, so there is no need to test if cards of
that type are in order since there can only be one of them. For example:
http://www.fossil-scm.org/fossil/artifact/6841ee6452?ln=459
For other cards, there are checks to make sure they are in strict order.
For example, the F card:
http://www.fossil-scm.org/fossil/artifact/6841ee6452?ln=556-558
We could add a check at the top of the manifest parser loop to check every
card using strcmp(). But that would slow down processing in a performance
critical section of the code, so I left that out.
If you do find a case there cards are not checked for strict ordering, then
that is a bug that needs fixing.
--
D. Richard Hipp
[email protected]
_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
