2014-03-05 12:39 GMT+01:00 Stephan Beal <sgb...@googlemail.com>:
> On Wed, Mar 5, 2014 at 10:08 AM, Jan Nijtmans <jan.nijtm...@gmail.com>
> wrote:
>>
>> 2014-03-05 7:51 GMT+01:00 Andy Bradford <amb-fos...@bradfords.org>:
>> > Also, clicking the button to reveal the non-whitespace change
>> > is no more ``correct'' than if Joel had instead changed ``Listening'' to
>> > ``listening'' on one of those lines. It would still show Joel as the
>> > ``author'' of that line, but really he simply made a minor modification
>> > to it while drh was the original author. Should Fossil be concerned
>> > about authors of bytes in annotate/blame?
>>
>> Sorry, I respectfully disagree. Changing "Listening" to "listening" is
>
>
> By removing the "if", Joel changed the semantics (not only the indentation)
> of the code. i would argue that he is indeed the one who should be "blame"d
> in that case.
I can see both arguments very well. What's a pity is that the "diff-eolws"
branch started with diff behavior correction. Annotation uses the diff
logic, but I would like to keep this separate from the work that has been
done on this branch.
Therefore I reverted the "diff-eolws" branch diffFlags to what they
are in trunk now: DIFF_IGNORE_EOLWS.
Question to anyone interested:
What should be the diffFlags used for blame/annotate
1) DIFF_IGNORE_EOLWS (the current behavior, ignoring all
end-of-line spacing)
2) DIFF_IGNORE_SOLWS|DIFF_IGNORE_EOLWS (my preference, ignoring
all start-of-line and end-of-line spacing)
3) 0: Any difference in spacing is considered different
4) Any other flag, to-be-implemented.
Thanks for all reactions!
Regards,
Jan Nijtmans
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
