The scenario I'd like to see supported is roughly as follows:
Work on a release is done. The release manager closes the branch so no one
can accidentally merge or commit to it.
A bug fix is needed. The developer branches off the closed node and fixes
the bug and runs QA.
The release manager can examine the bug fix, assess the QA results and then
open the closed branch, merge the fix and re-close.
I think this is a useful release flow.
On Fri, Jul 18, 2014 at 11:23 AM, Ron W <ronw.m...@gmail.com> wrote:
> On Fri, Jul 18, 2014 at 1:16 PM, Stephan Beal <sgb...@googlemail.com>
> wrote:
>
>>
>> On Fri, Jul 18, 2014 at 6:06 PM, Matt Welland <estifo...@gmail.com>
>> wrote:
>>
>>> It seems it is not possible to commit to a new branch from a closed
>>> branch. this is version 1.28.
>>>
>>> I think this should be allowed. Closing a branch only implies to me that
>>> no more commits are to be made to that branch.
>>>
>>
>> The offending code is in checkin.c:
>>
>> /*
>> ** Do not allow a commit against a closed leaf
>> */
>> if( db_exists("SELECT 1 FROM tagxref"
>> " WHERE tagid=%d AND rid=%d AND tagtype>0",
>> TAG_CLOSED, vid) ){
>> fossil_fatal("cannot commit against a closed leaf");
>> }
>>
>> i unfortunately cannot say how that query needs to be changed to catch
>> that, but i'm betting that Jan can.
>>
>
> To get the feature Matt suggested, I suggested adding a new Fossil defined
> tag and adding the the following after the code cited above (inserting the
> needed conditional in the new if):
>
> /*
> ** If not creating a new branch, do not allow a commit against a closed
> branch
> */
> if( /* not creating new branch */ ){
> if( db_exists("SELECT 1 FROM tagxref"
> " WHERE tagid=%d AND rid=%d AND tagtype>0",
> TAG_BRCLOSED, vid) ){
> fossil_fatal("cannot commit into a closed branch");
> }
> }
>
>
> _______________________________________________
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
>
--
Matt
-=-
90% of the nations wealth is held by 2% of the people. Bummer to be in the
majority...
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
