On Sun, Jul 27, 2014 at 3:22 PM, Jan Nijtmans <jan.nijtm...@gmail.com> wrote:
> 2014-07-26 5:08 GMT+02:00 Joe Prostko <joe.pros...@gmail.com>:
>> Using the handy `fossil bisect`, I found that this revision is causing
>> me problems while compiling Fossil from within Haiku.
>
> Should be fixed here:
>     <http://fossil-scm.org/index.html/info/14aea4f883>
>
> Thanks for the report.

Confirmed as fixed on Haiku, and compiles/works fine on this Manjaro
machine as well.  Thank you!

> The real issue was that although SQLite is supposed to be
> compiled with NDEBUG=1, this macro was defined too
> late, after the inclusion of the first <assert.h>. This resulted
> in the TESTONLY macro to be an empty define, but the
> assert() macro was not empty. On most platforms (e.g. linux)
> the assert() macro is re-defined every time when <assert.h>
> is included again, then this problem is not noticed. However,
> it really was a problem in fossil's build system, which
> caused fossil's embedded SQLite to be compiled in
> debug mode :-( This side-effect was not intentional!

I had honed in on the problem being related to NDEBUG, but didn't get
any farther than that.  I am glad you were able to figure this out,
and that the fix helped to address a Fossil bug as well.  :)

- joe
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to