Thus said Kelly Dean on Sun, 04 Jan 2015 04:21:55 +0000: > Yesterday, the network probably dropped some packets. But it's > misleading, at least for a new user, for Fossil to report that the > clone finished when it actually didn't.
I have not been able to reproduce this problem. Do you have any more details about what might have caused this? I'm not sure how dropped packets could cause this. Presumably if packets are being dropped, TCP/IP will take care to retransmit them. If the connection times out then I would expect the whole operation to fail and the repository be deleted. Also, the server should have sent the project-id with the very first response to the clone request (and each subsequent response). I wonder what was sent... If you can reproduce the problem, perhaps you could use --httptrace when cloning to see if it was actually sent. > It would be useful for the server to send a top-level hash of all the > data, before sending the data, so the client can verify it after the > download, and not report that the clone finished if the hash doesn't > verify. I'm curious what Fossil would do with one of the partial clones that you got. What happens if you try to pull into one of the partial clones? fossil pull -R fossil-src-2.fossil https://www.fossil-scm.org/ > Since Fossil already treehashes everything, and the file format spec > says repository synchronization uses a ``cluster'' with a top-level > hash of all the data, I don't see why the cluster wouldn't be sent > first, and the full tree verified after the download. Clusters are actually not used during cloning. When you clone, the server simply bundles up all known public artifacts and ships them with the cfile card (used with clone protocol 3). > BTW it would be useful to send the total size in advance too, so the > client can show a progress report. That would probably require a new clone protocol to implement so the server that implements it knows not to send the information to a client that is unable to handle it. Might be useful, especially if you haven't already looked at the size of the repository using: https://www.fossil-scm.org/index.html/stat Andy -- TAI64 timestamp: 4000000054ab9b4b _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
