On Thu, Feb 5, 2015 at 5:12 PM, Abilio Marques <abili...@gmail.com> wrote:
> Yeah, missed the attach... > src/popen.c does a lot of the same stuff except... it fails fatally on error instead of returning TH_ERROR. Pedantically speaking, i prefer using error codes (like your patch), but fossil has a long history of fatally failing on errors, so my instinct would be to re-use popen.c's APIs, rather than duplicating functionally equivalent code (assuming popen.c meets all your needs - maybe it doesn't). Just my €0.02 - do not consider it to be "official"! -- ----- stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
