On 2/9/15, j. van den hoff <veedeeh...@googlemail.com> wrote: > in view of this I would be really glad to learn why the variable length > sha1 substrings as they are appearing in the timeline (and usual `finfo' > output without the `-b' flag) are beneficial rather than always just using > the fixed length substrings as they are used by `finfo -b' (which I would > find principally preferable) ? >
Showing 40 characters of SHA1 hash everywhere is overkill, everyone agrees. The question is how much of a prefix to show. Different sections of the Fossil code where written by different people at different times over the past 7.5 years, and differing decisions were made each time. Sometimes the code says "%.10s". Sometimes it says "%.NNs" for some other integer NN. Sometimes it says "%S" (capital "S") which is suppose to use the "standard length prefix", whatever that happens to be. Sometimes the code manually inserts a \000 into the SHA1 string someplace and then calls "%s". Probably we would be well-served to clean this all up. But first all the committers have to agree on a particular style to use. Then we have to hunt down and change every place that prints out a SHA1 hash. And, so far, everybody has felt that it works well enough as it is and nobody has put in the effort to clean things up. -- D. Richard Hipp d...@sqlite.org _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
